Opened 8 years ago

Closed 4 years ago

#16 closed defect (fixed)

'Restore Brush' function on Brush Grab and Lasso buttons differs

Reported by: finticemo Owned by: PulkoMandy
Priority: major Milestone: 2.6
Component: GrafX2 Version: 2.4
Keywords: Cc:

Description

.. This is directly contrary to the help, which explicitly identifies the Restore Brush function as 'same as above'

Specifically, this is what occurs (I am assuming you have already grabbed a brush sometime in this GrafX2 session):

  • Right Clicking on the Brush Grab button restores your brush. The Brush button shows the 'multicolor brush' symbol.
  • Right Clicking on the Lasso button sets your brush to a 1px brush. However, the Brush button shows the 'multicolor brush' symbol, which is incorrect: this 1px brush behaves in all ways identical to the standard 1px brush, including adapting its color to the current Fore-color.

I am not sure whether it is the documentation that is wrong, or the code. But the documentation and the code clearly do not match up.

Change History (10)

comment:1 by Thomas Bernard, 5 years ago

@Pulkomandy : What should be done in your opinion ?

comment:2 by PulkoMandy, 5 years ago

It seems to be a bug indeed. The "restore" should do the same thing on the two buttons.

Going back to the 1px brush is already easily accessible using the DEL key.

comment:3 by yrizoud@…, 5 years ago

The reason is that the visual de-activation of the Lasso button calls Button_Unselect_lasso(), which assumes that the button had been activated through left-click, saving the "original paintbrush" in variable Paintbrush_shape_before_lasso.
I can't see an evident fix at the moment.

comment:4 by PulkoMandy, 5 years ago

Milestone: 2.52.6

comment:5 by PulkoMandy, 5 years ago

Owner: changed from Adrien Destugues to PulkoMandy
Status: newassigned

comment:6 by Jordan Christiansen, 4 years ago

I'm working on debugging this. One thing I've noticed is that if you have a brush that you lasso'ed and you use the lasso tool again, from that point on the lasso restore function seems to work correctly, no matter how many times you change brushes or use the lasso tool.

For anyone who needs this to work right now, this could be a temporary workaround.

I'll try to figure this out and submit a patch.

comment:7 by PulkoMandy, 4 years ago

Great, thanks for working on it! Let us know if you need any help with this.

comment:8 by Jordan Christiansen, 4 years ago

comment:9 by Jordan Christiansen, 4 years ago

My patch was merged, so this can be close now.

comment:10 by PulkoMandy, 4 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.