Recent releases for macOS do not have version information

[Carl Frank]

macOS apps need the CFBundleVersion and CFBundleShortVersionString keys set in Info.plist to display version information.

Older versions of Grafx2 always set CFBundleVersion as 1.0, but CFBundleShortVersionString had version information. In recent releases, CFBundleShortVersionString is empty.

Having accurate version information is useful for macOS to behave correctly with the app, and for third-party apps to interact with it.

[Thomas Bernard]

I can see

	<key>CFBundleVersion</key>
	<string>1.0</string>

in the Info.plist file, and

CFBundleShortVersionString = "Grafx2 version 2.7.2942";

in English.lproj/InfoPlist.string.

@Carl Frank : could you provide correct Info.plist and InfoPList.string files so I update them ?
Regards.

[Carl Frank]

Technically, even those old versions are wrong. CFBundleVersion should not remain static and CFBundleShortVersionString should just be the version, not have "Grafx2 version" in there. The correct values would be CFBundleVersion as 3104 and CFBundleShortVersionString as 2.8.

But if we're going for _consistency_, the attached Info.plist should be enough to fix it. Only change I made was to add to it:

<key>CFBundleShortVersionString</key>
<string>Grafx2 version 2.8.3104</string>

The key did not exist in the file. You cannot localize (which is what the .strings file is for) a non-existent key.

Why have that localization file in the first place. It’s only one language and it’s only copyright information wich seldom changes, why not just add the keys directly to Info.plist?

[Thomas Bernard]

​https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleversion
says CFBundleVersion should be x.y.z

Same for CFBundleShortVersion :
​https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleshortversionstring

[Thomas Bernard]

can you try to download ​https://pulkomandy.tk/projects/GrafX2/downloads/69 and tell me if it is better ?

[Thomas Bernard]

see ​https://gitlab.com/GrafX2/grafX2/-/merge_requests/322

[Thomas Bernard]

The things are the way they are for a long time ;)
it is never too late to fix them, but I think you are the first to complain
​https://gitlab.com/GrafX2/grafX2/-/blame/master/src/Info.plist
​https://gitlab.com/GrafX2/grafX2/-/commits/master/src/English.lproj/InfoPlist.strings

[Carl Frank]

I confirm that build is good! Thank you for being so responsive and fast to fix!