Opened 4 years ago

Closed 13 months ago

#47 closed enhancement (fixed)

somehow make it visible what page is active

Reported by: HoraK-FDF Owned by: PulkoMandy
Priority: major Milestone: 2.7
Component: GrafX2 Version: 2.5
Keywords: Cc:

Description (last modified by PulkoMandy)

Hi,

i had edited some animations that look nearly the same the one to change on the normal page and one with the changes already done on the spare page so i switched many times between the two but at some point i lost the track and don't could find out without walking thru the frames where i was the first part of the file name was also the same so that that was also not possible to determine it by looking at it on the bottom status bar.
So i think it would be nice if there would be a way to somehow make it visible, the best way i think is to make a new button in the skin itself so i modified the skins so that it is visible what i mean. I have put the button at x=254 y=26 there was space on all skins. That's only a suggestion how it could be done the creators of the skins might want to do it in another way (if the enhancement gets accepted in that way) i also took some colors other than the 4 last colors to draw the button on some skins so it should not be right anyhow.

Attachments (5)

skin_Aurora.png (27.3 KB) - added by HoraK-FDF 4 years ago.
skin_classic.png (17.0 KB) - added by HoraK-FDF 4 years ago.
skin_DPaint.png (15.8 KB) - added by HoraK-FDF 4 years ago.
skin_modern.png (20.5 KB) - added by HoraK-FDF 4 years ago.
skin_scenish.png (19.8 KB) - added by HoraK-FDF 4 years ago.

Download all attachments as: .zip

Change History (15)

Changed 4 years ago by HoraK-FDF

Attachment: skin_Aurora.png added

Changed 4 years ago by HoraK-FDF

Attachment: skin_classic.png added

Changed 4 years ago by HoraK-FDF

Attachment: skin_DPaint.png added

Changed 4 years ago by HoraK-FDF

Attachment: skin_modern.png added

Changed 4 years ago by HoraK-FDF

Attachment: skin_scenish.png added

comment:1 Changed 4 years ago by pulkomandy

Description: modified (diff)

The program does not know which page is main or spare. When you switch, the spare becomes main, and the main becomes spare. This works like two independant documents in an editor. So, there is no direct way to do that currently.

comment:2 Changed 4 years ago by HoraK-FDF

so would add an variable that is set to 0 at start (0=normal page) and then set it to 1 (1=spare page) if spare page button is pressed and if again pressed set back to 0 and so on do the trick? At start even when you start GrafX2 with an file on the command line it is always on the normal page. And then simply ask:
if (var) then draw spare page button
else draw normal button

comment:3 Changed 4 years ago by HoraK-FDF

i have just included a Current_page variable in the rev 2171

in the program init i set it to 0
in Button_page i do

  if (!Current_page) 
   Current_page=1;
  else
   Current_page=0;

then i modified the following functions to use this variable:
getpicturesize
getsparepicturesize
getlayercount
getsparelayercount

it works very well no mater on what page i'm it gives me the right values. So i think it would be a good way to know on what side grafx2 currently is.

comment:4 Changed 2 years ago by PulkoMandy

Milestone: 2.52.6

comment:5 Changed 2 years ago by PulkoMandy

Owner: changed from pulkomandy to PulkoMandy
Status: newassigned

comment:6 Changed 22 months ago by yrizoud@…

A separate improvement may be that when the filemames of main and spare have the same beginning, the part that we display should rather be the ending. (using …<ending>.<ext> instead of <beginning>….<ext>)
It would solve typical cases of:
spritewithlongname00.gif
spritewithlongname01.gif
spritewithlongname01 Copy.gif

comment:7 Changed 19 months ago by PulkoMandy

Description: modified (diff)

In the skinfiles, the button should rather go with the alternate button set (below the cursors)

comment:8 Changed 18 months ago by Thomas Bernard

I don't think we need to display more than the filename to identify the "main" or "spare" pages.

But as Yves pointed out, if the beginning of the filename are the same, that's a problem.
See my changes :
https://gitlab.com/GrafX2/grafX2/merge_requests/150

diplay : …lename_end.ext
instead of : finename_begin…

comment:9 Changed 17 months ago by PulkoMandy

Milestone: 2.62.7

Move open tickets to 2.7 milestone

comment:10 Changed 13 months ago by PulkoMandy

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.