Opened 3 years ago

Closed 2 years ago

#60 closed defect (fixed)

Ubuntu doesnt need iconv. build fails

Reported by: yakumo9275@… Owned by: pulkomandy
Priority: minor Milestone: 2.5
Component: GrafX2 Version: 2.4
Keywords: iconv, ubuntu Cc:

Description

Makefile has "-liconv" this is invalid on all the ubuntu deriviatives, maybe deiban as well, as iconv is part of libc, make files with -liconv present.

I dont know how to 'detect' if its needed or not to make the makefile work properly depending on which linux system its on (sorry I dont have a patch).

Change History (4)

comment:1 Changed 3 years ago by PulkoMandy

Can't we use pkg-config to detect it?

comment:2 Changed 2 years ago by Thomas Bernard

iconv is now part of libc as of POSIX 2008, so -liconv can be safely removed I think...

comment:3 Changed 2 years ago by Thomas Bernard

you fixed it with https://gitlab.com/GrafX2/grafX2/commit/c0e625fdef84bf48b09dc4c9163a1cd4bbf20f6e#09a8e11089bd7b184c2ba7778565c1350e1c7e3a_398_400

It is difficult to auto detect the need of -liconv without some kind of configure script...

comment:4 Changed 2 years ago by PulkoMandy

Resolution: fixed
Status: newclosed

Yes, sounds good enough for now.

Note: See TracTickets for help on using tickets.