Opened 3 years ago

Closed 3 years ago

#76 closed enhancement (fixed)

Allow setting image size from commandline

Reported by: Philip Linde Owned by: pulkomandy
Priority: minor Milestone:
Component: GrafX2 Version:
Keywords: Cc:

Description

I would like to minimize the boilerplate setup for an image when I start grafx2, booting right into a picture with the dimensions I need. I suggest having a -size parameter that allows you to specify the picture size from the command line separately from the video mode.

I have a small patch but I haven't spent much time reading the source code, so it may be off from the preferable approach. One consideration is how to handle setting both the size and loading a picture. Ignore it silently, fail, crop image? In my patch it happens to be ignored silently as a side effect.

Attachments (1)

size.patch (6.8 KB) - added by Philip Linde 3 years ago.
Patch implementing -size commandline parameter

Download all attachments as: .zip

Change History (4)

Changed 3 years ago by Philip Linde

Attachment: size.patch added

Patch implementing -size commandline parameter

comment:1 Changed 3 years ago by Thomas Bernard

looks good to me.

you could make a Merge request on gitlab :
https://gitlab.com/GrafX2/grafX2

comment:2 Changed 3 years ago by Philip Linde

Thanks for the quick response. I have opened merge request 61.

comment:3 Changed 3 years ago by PulkoMandy

Resolution: fixed
Status: newclosed

Merged, thanks!

Note: See TracTickets for help on using tickets.