Opened 5 years ago
Closed 5 years ago
Last modified 5 years ago
#80 closed defect (invalid)
Release 2.5 will not build with Makefile for Fedora 28.
|Reported by:||Christopher Rodriguez||Owned by:||pulkomandy|
In trying to package GrafX2 for Fedora 28, I came across an omission in the Makefile (specifically for Linux). As is,
make install fails with errors about missing directories. Patch attached fixes the issue entirely.
Change History (9)
by , 5 years ago
comment:1 by , 5 years ago
|Priority:||major → trivial|
|Status:||new → closed|
This bug has already been fixed : https://gitlab.com/GrafX2/grafX2/commit/8e94f338dff72024ec4e1e1ecd15aa8271ff8317
comment:2 by , 5 years ago
We should probably make an updated source/binary package of the 2.5 release with bugfixes included?
comment:3 by , 5 years ago
This patch isn't already included in grafx2-2.5.1960-src.tgz ?
comment:4 by , 5 years ago
I just checked : Yes it is !
comment:5 by , 5 years ago
Allright then. Cristopher, which source did you use? Maybe we forgot to update a download link somewhere?
comment:6 by , 5 years ago
I checked out the source for the latest release tag.
v2.5.1960 is a bugfix release, could it be tagged as such in the repo?
I see on the Downloads page for this site there's a source download that lists the package You mentioned (thanks, saves me the trouble of maintaining a patch), but it's below the "Get the Sourcecode" section.
The first bullet directed me to the gitlab repo, which is as far as I read, since I'm used to working with git. The second bullet mentions You hosting a source package below, but doesn't mention that the hosted package might contain bugfixes not present in the tagged releases.
comment:7 by , 5 years ago
If you prefer, you can rely on the tagged release from gitlab and integrate the 8e94f338dff72024ec4e1e1ecd15aa8271ff8317 patch.
I don't know what is more convenient for you with the fedora packet building system
comment:8 by , 5 years ago
Well, while we're at it I'd rather have a version with all the bugfixes (also the operation/cursor mapping bug, for example).
I think we should tag https://gitlab.com/GrafX2/grafX2/commit/0936118568bb06b7823e461da9945d4b57d0d636 as a bugfix for 2.5. Will do it in the evening if everyone is ok with it.