Opened 2 years ago

Closed 19 months ago

#81 closed defect (fixed)

Light_color/Dark_color settings are ignored

Reported by: PulkoMandy Owned by: Thomas Bernard
Priority: major Milestone: 2.6
Component: GrafX2 Version: 2.5
Keywords: Cc:

Description

We have settings to change the Dark_color and Light_color and colorize the menu (who wants boring grey?). But they are currently not plugged to anything. We should enable them again.

Change History (5)

comment:1 Changed 19 months ago by Thomas Bernard

they are loaded as Config.Fav_menu_colors[1] (Dark_color) and Config.Fav_menu_colors[2] (Light_color)

comment:2 Changed 19 months ago by Thomas Bernard

Just uncommenting the code there :
https://gitlab.com/GrafX2/grafX2/blob/master/src/main.c#L959
seems to make it work...

comment:3 Changed 19 months ago by Thomas Bernard

Owner: changed from pulkomandy to Thomas Bernard
Status: newaccepted

comment:4 Changed 19 months ago by yrizoud@…

This is a feature that I did like in the MS-DOS version. It is equally restored in the sdl2 branch, but it was a easier choice because it's full 24bit mode for the UI, no need to enforce the editor's colors into the image's 256 colors.
Now remains the question of providing an in-program setting for it, probably in Skin menu (which is easier to customize).

comment:5 Changed 19 months ago by Thomas Bernard

Resolution: fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.