Opened 4 years ago

Closed 3 years ago

#105 closed enhancement (fixed)

minimize the number of .C files that include <windows.h>

Reported by: Thomas Bernard Owned by: Thomas Bernard
Priority: minor Milestone: 2.8
Component: GrafX2 Version: 2.6
Keywords: win32 Cc:

Description

<windows.h> pollutes the global namespace a lot
(see http://pulkomandy.tk/projects/GrafX2/ticket/99)

Change History (4)

comment:1 by Thomas Bernard, 4 years ago

and also there is our own windows.h... shouldn't us rename it to gfx2windows.h or something ?

#include <windows.h>
#include "windows.h"

comment:2 by Thomas Bernard, 4 years ago

there is OS dependent code in many places we'll need to put some of theses in separate .c files.
I have already successfully removed <windows.h> from const.h ;)

​https://gitlab.com/GrafX2/grafX2/merge_requests/204

comment:3 by PulkoMandy, 3 years ago

Milestone: 2.7 → 2.8

comment:4 by Thomas Bernard, 3 years ago

Resolution: → fixed
Status: assigned → closed
Note: See TracTickets for help on using tickets.