if clicked on not existent bockmark grafical display errors occur

[HoraK-FDF]

Hi,

here is how to reproduce the bug,

set an directory in the ini that not exist or set en existing directory and then delete it. Now press the bookmark button and it very often happens that the mouse cursor causes grafical errors i don't know maybe the save/load menu don't gets redrawn after the red flash. I attach a picture that shows the bug. Then there is also another part of the bug or its a standalone thing when clicked on an non existing bookmark and then fast on the file name edit bar it locks itself up in palette depending colors of the flash, for that i will also attach a pic.

[HoraK-FDF]

click on missing bookmark cursor bug

[HoraK-FDF]

click on missing bookmark stuck in the flash bug

[HoraK-FDF]

from the second stuck in the flash thing it only happens if it was clicked on a picture before and the stuck color disappears if clicked somewhere outside the file name edit bar, the bug can then go another step if after clicking on an picture it is clicked on a directory or "PARENT DIRECTORY" (only clicked on it and directory entered do the same) then the stuck color also remains if clicked outside the file name edit bar the only thing to get the right color back is to click on a picture or leave the save/load menu.

[Thomas Bernard]

I don't reproduce with the latest sources.
I've got a red flash when clicking on the boggus directory bookmark.

I'm under FreeBSD, but code doesn't seems to be very system dependent (chdir either fails or succeed)

[Thomas Bernard]

I reproduced when moving the mouse fast during the red flash.
It looks like a bug in the "red flash" function.

[PulkoMandy]

It's possible that the red flash code does not handle a visible mouse cursor. Originally it was designed for save/load where the cursor is hidden.

[Thomas Bernard]

Calling Error(0) with the cursor hidden causes the problem.
Adding Display_cursor(); just before and Hide_cursor(); just after fixes the issue

diff --git a/src/filesel.c b/src/filesel.c
index b0469df..b9f7a19 100644
--- a/src/filesel.c
+++ b/src/filesel.c
@@ -2090,7 +2090,11 @@ byte Button_Load_or_Save(T_Selector_settings *settings, byte load, T_IO_Context
           Highlight_file(Find_file_in_fileselector(&Filelist, previous_directory));
         }
         else
+        {
+          Display_cursor();
           Error(0);
+          Hide_cursor();
+        }
         // Affichage des premiers fichiers visibles:
         Prepare_and_display_filelist(Selector->Position,Selector->Offset,file_scroller);
         Display_cursor();

[Thomas Bernard]

Or else we could modify Error(0) so it doesn't call Delay_with_active_mouse()
but directly SDL_Delay()

[PulkoMandy]

I prefer the first solution, there is no need to freeze the mouse cursor during the red flash then.

[Thomas Bernard]

So I reproduced and understood the 2nd issue as well.

​https://gitlab.com/GrafX2/grafX2/merge_requests/16