Changeset 2711345 in Renga

Timestamp:

Mar 28, 2020, 2:03:17 PM (4 years ago)

Author:

Adrien Destugues <pulkomandy@…>

Branches:

main

Children:

400c21d

Parents:

d772d93

Message:

Trust gloox on SSL certificates validation

I checked the Gloox sources and it already validates the certificate
validity dates as well as the server name. There is nothing more we need
to validate. We may want better handling (explicit error on invalid SSL,
allowing to ignore certificate problems, allow the user to set up their
own certs, etc), but that can be tracked in separate issues.

Fixes #30

Files:

• doap.xml (modified) (1 diff)
• network/GlooxHandler.cpp (modified) (1 diff)
• ui/RegisterAccountWindow.cpp (modified) (2 diffs)

doap.xml

@@ -58 +58 @@
         <!-- Do we handle 6122 or rather 7622? -->
     <implements rdf:resource="https://xmpp.org/rfcs/rfc6122.html"/>
-        <!-- TODO <implements rdf:resource="https://xmpp.org/rfcs/rfc7590.html"/> -->
+        <implements rdf:resource="https://xmpp.org/rfcs/rfc7590.html"/>
         <!-- TODO: https://github.com/HaikuArchives/Jabber4Haiku/issues/29 -->
     <!--<implements rdf:resource="https://xmpp.org/rfcs/rfc5122.html"/>-->

network/GlooxHandler.cpp

@@ -220 +220 @@
 
 
-bool GlooxHandler::onTLSConnect(const gloox::CertInfo& info __attribute__((unused)))
-{
+bool GlooxHandler::onTLSConnect(const gloox::CertInfo& info)
+{
+        // TODO let the listener (if any?) decide what to do with invalid
+        // certificates. Add the relevant info to the notice, and wait for a
+        // reply before moving on. But what if the listener does not reply or if
+        // there is no listener? 
+
+        // TODO add the relevant fields to the notice so the listener can make a
+        // decision
         SendNotices(kTLSConnect);
-        // TODO let the listener (if any?) decide what to do
-        return true;
+        return info.status == gloox::CertOk;
 }
 

ui/RegisterAccountWindow.cpp

@@ -346 +346 @@
                                 {
                                         // TODO handle only if there is no dataform
-                                        puts("yay, fields");
                                         break;
                                 }
@@ -367 +366 @@
                                 case kOOB:
                                 {
+                                        // TODO handle out of band data
                                         message->PrintToStream();
                                         //handleOOB(...);