Changeset b3285d3 in Renga

Timestamp:

Nov 19, 2023, 10:41:05 AM (6 months ago)

Author:

PulkoMandy <pulkomandy@…>

Branches:

main

Children:

fc6fa74

Parents:

79488d0

Message:

Fix debugger() call on application exit

Incorrect reference counting of TextDocument led to it not being
destroyed, and a static BulletData being destroyed while there still
were references to it.

Files:

• jabber/BlabberApp.cpp (modified) (1 diff)
• support/main.cpp (modified) (2 diffs)
• ui/TalkView.cpp (modified) (1 diff)
• ui/TalkView.h (modified) (1 diff)

jabber/BlabberApp.cpp

@@ -32 +32 @@
 }
 
-BlabberApp::~BlabberApp() {
+BlabberApp::~BlabberApp()
+{
         // take down the message repeater
         MessageRepeater::Instance()->Lock();

support/main.cpp

@@ -7 +7 @@
 #include "jabber/BlabberApp.h"
 
+#include <stdio.h>
+
 int main(__attribute__((unused)) int argc, char **argv) {
         // record app location
@@ -12 +14 @@
         
         // create application
-        BlabberApp *blabber = new BlabberApp();
+        BlabberApp blabber;
         
         // start application
-        blabber->Run(); 
+        blabber.Run();
 
         // success on exit

ui/TalkView.cpp

@@ -101 +101 @@
 
         fTimeline         = new TextDocumentView("Timeline");
-        fTimelineDocument = new TextDocument();
+        fTimelineDocument.SetTo(new TextDocument(), true);
         fTimeline->SetTextDocument(fTimelineDocument);
         fTimelineScroller = new BScrollView("Timeline Scroller", fTimeline, B_WILL_DRAW, false, true);

ui/TalkView.h

@@ -134 +134 @@
         BScrollView        *fTimelineScroller;
         TextDocumentView   *fTimeline;
-        TextDocument       *fTimelineDocument;
+        TextDocumentRef    fTimelineDocument;
 
         BScrollView        *fMessageInputScroller;