Opened 4 months ago

Closed 4 months ago

#167 closed defect (fixed)

Recent releases for macOS do not have version information

Reported by: Carl Frank Owned by: Thomas Bernard
Priority: minor Milestone:
Component: GrafX2 Version: 2.9WIP
Keywords: Cc:

Description

macOS apps need the CFBundleVersion and CFBundleShortVersionString keys set in Info.plist to display version information.

Older versions of Grafx2 always set CFBundleVersion as 1.0, but CFBundleShortVersionString had version information. In recent releases, CFBundleShortVersionString is empty.

Having accurate version information is useful for macOS to behave correctly with the app, and for third-party apps to interact with it.

Attachments (1)

Info.plist (904 bytes ) - added by Carl Frank 4 months ago.

Download all attachments as: .zip

Change History (9)

comment:1 by Thomas Bernard, 4 months ago

I can see

	<key>CFBundleVersion</key>
	<string>1.0</string>

in the Info.plist file, and

CFBundleShortVersionString = "Grafx2 version 2.7.2942";

in English.lproj/InfoPlist.string.

@Carl Frank : could you provide correct Info.plist and InfoPList.string files so I update them ?
Regards.

by Carl Frank, 4 months ago

Attachment: Info.plist added

comment:2 by Carl Frank, 4 months ago

Technically, even those old versions are wrong. CFBundleVersion should not remain static and CFBundleShortVersionString should just be the version, not have "Grafx2 version" in there. The correct values would be CFBundleVersion as 3104 and CFBundleShortVersionString as 2.8.

But if we're going for _consistency_, the attached Info.plist should be enough to fix it. Only change I made was to add to it:

<key>CFBundleShortVersionString</key>
<string>Grafx2 version 2.8.3104</string>

The key did not exist in the file. You cannot localize (which is what the .strings file is for) a non-existent key.

Why have that localization file in the first place? It’s only one language and it’s only copyright information wich seldom changes, why not just add the keys directly to Info.plist?

Last edited 4 months ago by Carl Frank (previous) (diff)

comment:4 by Thomas Bernard, 4 months ago

Owner: changed from pulkomandy to Thomas Bernard
Status: newaccepted

can you try to download https://pulkomandy.tk/projects/GrafX2/downloads/69 and tell me if it is better ?

comment:6 by Thomas Bernard, 4 months ago

The things are the way they are for a long time ;)
it is never too late to fix them, but I think you are the first to complain
https://gitlab.com/GrafX2/grafX2/-/blame/master/src/Info.plist
https://gitlab.com/GrafX2/grafX2/-/commits/master/src/English.lproj/InfoPlist.strings

comment:7 by Carl Frank, 4 months ago

I confirm that build is good! Thank you for being so responsive and fast to fix!

comment:8 by Thomas Bernard, 4 months ago

Resolution: fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.