Opened 8 years ago
Closed 6 years ago
#24 closed task (fixed)
Unfinished save/load in Palette
Reported by: | yrizoud | Owned by: | Thomas Bernard |
---|---|---|---|
Priority: | major | Milestone: | 2.5 |
Component: | GrafX2 | Version: | 2.5 |
Keywords: | Cc: |
Description
Load does nothing
Save lets you pick image formats, IMO it should restrict to palette-only formats. Similarly, palette-only formats should not be proposed in file selectors for image and brush : This would save some space in the "formats" dropdown list, which is already too long (it crashes if the dropdown exceeds the window bottom, and the file selector is dragged to the bottom).
By the way, it would be very helpful if loading a palette would ask the user if he wants to remap the image (new) or not.
Attachments (2)
Change History (8)
comment:1 by , 6 years ago
comment:2 by , 6 years ago
The idea for load was to allow loading only the palette from an image (not only a .PAL file). This can be done by using a different "io context" (as is already the case for loading a preview vs loading "for real").
comment:3 by , 6 years ago
I think it is almost implemented, only some minor issues.
https://gitlab.com/miniupnp/grafX2/tree/load_palette
by , 6 years ago
Attachment: | grafx2_palette_load.png added |
---|
bug in the lower part of the screen after loading palette
comment:4 by , 6 years ago
Owner: | changed from | to
---|---|
Status: | new → accepted |
comment:5 by , 6 years ago
I have something which works well :
https://gitlab.com/GrafX2/grafX2/merge_requests/19
by , 6 years ago
Attachment: | load_palette_OK.png added |
---|
it's now working. Move windows to test that Backgrounds are properly updated
comment:6 by , 6 years ago
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
I tested with the latest code.
1) Load palette is still unimplemented. TODO
I think we could reuse the general Load dialog and display the 256 colors (16x16 pixels) in the preview zone
2) Save palette is now only proposing palette formats since commit 2f3c55477e45567d50ae5699cc412452428484ac
https://gitlab.com/GrafX2/grafX2/commit/2f3c55477e45567d50ae5699cc412452428484ac