Opened 14 months ago

Last modified 5 months ago

#126 new defect

Safety colors = yes is ignored by palette editor

Reported by: HoraK-FDF@… Owned by: pulkomandy
Priority: major Milestone: 2.8
Component: GrafX2 Version: 2.7
Keywords: Cc:

Description

Hi,

to reproduce start gfx2 simply open palette editor press zap unused then manually slide down the last three colors and all is black or if you stopped earlier only certain details are remaining visible, by pressing ok this state is also carried over and gfx2 stays that way.

tested with grafx2-2.7wip2732-issue_123

Change History (12)

comment:1 Changed 14 months ago by yrizoud@…

If the option was applied after every palette change, it would actually cancel your action on colors used by the menus (if your image doesn't use them yet), making them read-only. It would not be a good thing.

Note that the option is only meant as a safety, for example after a zap on an empty image that would produce a full-black palette. In any other case, Grafx2 will pick from whatever colors are available in the image's palette. You can always re-create the default menu colors at any time by pressing Backspace in the Palette screen (it will pick 4 unused slots, starting at the end).

comment:2 Changed 14 months ago by HoraK-FDF@…

but should it not then at least reinsert the safety colors after pressing ok?

comment:3 Changed 14 months ago by PulkoMandy

No, because you can really use all 256 colors for your picture. So it should only apply them when you do something that could clear all colors to black (zapping all colors, for example). Otherwise, the menu will just pick 4 reasonable colors from the image palette.

comment:4 Changed 14 months ago by HoraK-FDF@…

but there are no 4 reasonable colors to pick anymore if you zapped and slided the last four down.

comment:5 Changed 14 months ago by Thomas Bernard

in that case you press Backspace....

comment:6 Changed 14 months ago by HoraK-FDF@…

ok than but isn't the backspace feature a bit strange I mean if I press backspace on a full palette with lots of colors that are useable for safety colors It overwrites the last four ones should it not look first in the palette if available colors are there near the menu colors instead of searching unused colors and replace them?

comment:7 Changed 14 months ago by Thomas Bernard

so don't press backspace in that case...

comment:8 Changed 13 months ago by Thomas Bernard

by the way I think we should make sure the documentation is explicit about the key shortcut in the palette editor and what are the consequences in terms of menu colors.

what do you think of :

ESCAPE : cancel any palette modification and close palette dialog
ENTER : accept any palette modification and close palette dialog. Menu colors are updated to best match
BACKSPACE : emergency key : assign 4 unused palette slots to menu colors.

(inline doc is also available online : http://grafx2.gitlab.io/grafX2/htmldoc/grafx2_56.html )

comment:10 Changed 13 months ago by Thomas Bernard

Milestone: 2.7

@yrizoud@… @HoraK-FDF@… are you happy with the help improvement in https://gitlab.com/miniupnp/grafX2/commit/3a9d0a1a9b7246d070cdc5c376ca0976ca665d61 ?

comment:11 Changed 13 months ago by yrizoud@…

Fine by me. I tested with long shortcut names, it still fits.

comment:12 Changed 5 months ago by PulkoMandy

Milestone: 2.72.8
Note: See TracTickets for help on using tickets.